Fix logical comparision #265
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Please update fixtures under https://github.com/rectorphp/rector-downgrade-php/tree/main/rules-tests/DowngradePhp80/Rector/Expression/DowngradeThrowExprRector/Fixture and fix ci errors |
Member
|
Could you add new fixture for the usecase you have? |
Member
|
Oh, I see the fixture updated 👍 |
samsonasik
approved these changes
Jan 16, 2025
Member
samsonasik
left a comment
samsonasik
left a comment
There was a problem hiding this comment.
Looks good, let's give it a try 👍
Member
|
Thank you @iNem0o |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello
Here is the fix proposed in the DowngradeThrowExprRector logical error issue.
Why
When downgrading a coalesce operator that uses throw, there is a logical error in how the condition is generated. In the current implementation, the exception is thrown when the left-hand side is not null, but it should be thrown when the left-hand side is null.